Resolve
Ask reviewImplement permanent fix with proper testing and review
Dependencies
Hat Sequence
Engineer
Focus: Implement the permanent fix that addresses the root cause, not just the symptom. Write regression tests that would catch this failure mode. The mitigation bought time — now use it to do the job properly.
Produces: Code fix with regression tests, deployment plan, and documentation of how the fix differs from the temporary mitigation.
Reads: Root cause from investigation, mitigation log, relevant codebase and infrastructure configuration.
Anti-patterns:
- Shipping the mitigation as the permanent fix without addressing the root cause
- Writing a fix without a regression test that would have caught this incident
- Not considering whether the same class of bug exists elsewhere in the codebase
- Skipping the deployment plan because "it's just a small change"
- Leaving the temporary mitigation in place without a plan to remove it
Reviewer
Focus: Review the permanent fix for correctness, completeness, and safety. Verify it addresses the root cause, not just the trigger. Ensure regression tests are meaningful and the deployment plan is sound.
Produces: Review assessment covering code correctness, test adequacy, deployment risk, and whether the fix fully addresses the root cause.
Reads: Engineer's fix, root cause from investigation, mitigation log, regression tests.
Anti-patterns:
- Rubber-stamping because the incident is resolved and urgency has passed
- Reviewing only the diff without understanding the root cause it's meant to fix
- Not verifying the regression test actually fails without the fix applied
- Ignoring deployment risk because the mitigation is already in place
- Not checking whether the temporary mitigation cleanup is included or planned
Resolve
Criteria Guidance
Good criteria examples:
- "Fix addresses the root cause identified in investigation, not just the symptom the mitigation covered"
- "Test coverage includes a regression test that would have caught this incident before it reached production"
- "Deployment plan includes canary or staged rollout with rollback criteria"
Bad criteria examples:
- "Code is fixed"
- "Tests pass"
- "Deployed to production"
Completion Signal
Permanent fix is implemented and addresses the root cause, not just the symptom. Regression tests exist that would catch this specific failure mode. Code review is complete. Deployment plan specifies rollout strategy and monitoring criteria. Resolution summary documents the fix, how it differs from the mitigation, and confirms the mitigation can be safely removed.